Repository navigation
docs: add the security tradeoffs to the FAQ - #444
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a "What are the security tradeoffs?" entry to the README FAQ, right under "Is it safe?".
Why
Closes #441. "Is it safe?" only covers privacy. The new entry says what patching changes about Dia's own protection: no hardened runtime, a dylib loaded from Application Support, the local signing certificate, how DiaTweaks updates are checked, how the Passwords tweaks reach the password managers, when Dia updates are looked for, and what Restore leaves behind.
Proof
Docs only. Each line was checked against the code:
sign()andstageTweaksinsrc/diapatch/main.m,src/dylib/Updates/Updates.m, and the update level labels insrc/dylib/Settings/SoftwareUpdate.m.codesign -dshowsflags=0x0on the patched Dia andruntimeon the original.Tested on
Checklist