Repository navigation
fix(dylib): name the right folder to repair when Chrome is blocked - #443
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Couldn't write" alert for Allow iCloud Passwords and Allow iCloud Passkeys now names the folder that is actually blocked in its repair command.
Why
The command always named the parent of the file that failed. Without Chrome installed that folder doesn't exist, so the command failed with "No such file or directory" and the tweak could not be turned on. The alert now walks up to the nearest folder the user can open and write, and names the one below it. It offers no command when Application Support or Library is the blocked one. chmod uses u+rwX so folders become enterable too.
Proof
Each printed command was run, then the write retried:
Tested on
Checklist