Repository navigation
fix(dylib): stop the compact command bar text running under Go - #442
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Compact Command Bar now ends the text field 14 pt before the Go button, whatever width Go has.
Why
The field was narrowed by Go's intrinsic width, which Dia 1.57 reports as none, so the field always ended 27 pt from the bar's edge. The "Go ↵" pill is about 96 pt wide, so a long URL ran underneath it. The field now measures Go's frame and re-fits when Go changes between the arrow and the pill.
Proof
Before, text under the pill (gap −87 pt):
After, gap 14 pt at every typing step:
Tested on
Checklist