Skip to content

feat(dylib): add picture in picture appearance tweaks - #434

Open
Harshitbeni wants to merge 1 commit into
JaceThings:mainfrom
Harshitbeni:codex/pip-ui-submission
Open

Harshitbeni wants to merge 1 commit into
JaceThings:mainfrom
Harshitbeni:codex/pip-ui-submission

Conversation

@Harshitbeni

@Harshitbeni Harshitbeni commented Nov 13, 2026 •

Copy link
Copy Markdown

What

Add three independent PiP switches with red Settings icons: icon-only Back/Close buttons, responsive playback controls at 50% size, and hidden website names. The replacement overlay uses Dia's player state and native callbacks; disabling all switches restores native controls, and meeting/minimized windows stay native.

Why

Make PiP controls more compact while preserving playback actions, the hover overlay, and seeker behavior.

Proof

Before/after recording. It shows two seconds with native controls followed by two seconds with all three tweaks enabled, at the same PiP size and position. No labels or audio.

Preview files are supplied for the maintainer's wiki. The local-only preview loader is excluded from this PR.

Tested on

  • Dia 1.57.0 (90921): final native top-tab report, 107 scenarios, zero failures.
  • Dia 1.57.0 (90589): native sidebar report, 107 scenarios, zero failures; recorded appearance.
  • macOS 27.3 (26C5035r), Apple silicon.
  • Clean optimized build and make check passed on base a25b4c1. Current upstream 43b4ef4 merges cleanly; the PiP Objective-C files also pass a syntax check against its current headers.
  • Focused fixture passed: all seven switch combinations, responsive sizing, visibility, native callbacks, seeking, and cleanup.

The stock make test wrapper exceeded its two-minute wait. Both final native reports completed with zero failures. An initial top-tab run failed the existing window-appearance check; the baseline comparison and unchanged full rerun passed. Full reports and verification package.

Checklist

  • I tried to break this and fixed what I found
  • It works with tabs in the sidebar and tabs at the top
  • It works with each tweak on and off

Maintainer follow-up: publish the three PiP wiki pages, sidebar links, and Settings previews before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant