Repository navigation
feat(dylib): add picture in picture appearance tweaks - #434
Open
Harshitbeni wants to merge 1 commit into
Open
Harshitbeni wants to merge 1 commit into
Harshitbeni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add three independent PiP switches with red Settings icons: icon-only Back/Close buttons, responsive playback controls at 50% size, and hidden website names. The replacement overlay uses Dia's player state and native callbacks; disabling all switches restores native controls, and meeting/minimized windows stay native.
Why
Make PiP controls more compact while preserving playback actions, the hover overlay, and seeker behavior.
Proof
Before/after recording. It shows two seconds with native controls followed by two seconds with all three tweaks enabled, at the same PiP size and position. No labels or audio.
Preview files are supplied for the maintainer's wiki. The local-only preview loader is excluded from this PR.
Tested on
make checkpassed on base a25b4c1. Current upstream 43b4ef4 merges cleanly; the PiP Objective-C files also pass a syntax check against its current headers.The stock
make testwrapper exceeded its two-minute wait. Both final native reports completed with zero failures. An initial top-tab run failed the existing window-appearance check; the baseline comparison and unchanged full rerun passed. Full reports and verification package.Checklist
Maintainer follow-up: publish the three PiP wiki pages, sidebar links, and Settings previews before merging.