Add BASE (Bielefeld Academic Search Engine) fetcher - #16530
Draft
Developer-sam-ai wants to merge 5 commits into
Draft
Add BASE (Bielefeld Academic Search Engine) fetcher#16530Developer-sam-ai wants to merge 5 commits into
Developer-sam-ai wants to merge 5 commits into
Conversation
faneeshh
reviewed
Aug 12, 2026
| List<BibEntry> entries = new ArrayList<>(); | ||
| JSONObject result = jsonObject.optJSONObject("response").optJSONObject("result"); | ||
| if (result != null) { | ||
| JSONArray docs = result.optJSONArray("docs"); // TODO: confirm actual key name in real JSON response |
Collaborator
There was a problem hiding this comment.
Claude has assigned you a task here. I would never let Claude waiting like that.
Author
There was a problem hiding this comment.
Good catch cleaned up leftover comments, that comment just was to tell me where we wanna block the API access. Also implemented isValidkey()
This PR is still waiting on BASE API key +IP approval (applied 2days ago)
Thanks for flagging it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a skeleton
SearchBasedFetcherimplementation for BASE(Bielefeld Academic Search Engine). Refs #15016.
Status: Draft / Work in Progress
Currently blocked on BASE API key + IP approval — application submitted,
awaiting response (BASE states "within a few days").
Implemented so far:
BaseSearchFetcher,BaseSearchQueryTransformer)Remaining once API access is confirmed:
isValidKey()Related issues and pull requests
Refs #15016
AI usage
Used Claude (Claude Sonnet 5) to navigate existing fetcher patterns
(IEEE, SemanticScholar) and JabRef's fetcher documentation, and to
review code structure/formatting. Implementation is my own and I
understand it.
Checklist
CHANGELOG.mdin a way that can be understood by the average user