Skip to content

Add diagnostics UI and popup logging for native messaging flow - #699

Open
Siedlerchr wants to merge 6 commits into
mainfrom
safari-diagnostics-ui
Open

Add diagnostics UI and popup logging for native messaging flow#699
Siedlerchr wants to merge 6 commits into
mainfrom
safari-diagnostics-ui

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jul 17, 2026

Copy link
Copy Markdown
Member

Add diagnostics popup for troubleshooting native messaging

@Siedlerchr
Siedlerchr marked this pull request as ready for review July 17, 2026 21:37
koppor pushed a commit to JabRef/JabRef-Browser-Extension-experimental that referenced this pull request Jul 27, 2026
Comment thread src/entrypoints/options/main.js Outdated
async function init() {
const options = await restoreOptions();
checkConnections(options);
initDiagnostics();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get it: what's the difference between checkConnection and initDiagnostics? Both seem to just run sendNativeValidation?!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the naming to make it more clear.
CheckConnection also checks HTTP stuff.
initDiagnosticsbutton setups the buttons and displays the actual result of the native messaging command, and as I wrote, it explcitiy checks only native messaging

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, still don't quite the use case. It runs the same method that is already run...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct and wanted.
But different: the atomic connection check is only executed when the port changes or the options page is loaded.
Manual: For explicit troubleshooting without leaving the options page. And will display the json answer.

grafik

@tobiasdiez

Copy link
Copy Markdown
Member

Please change the PR title and description to use your own words. If I want AI to summarize a PR, I can do this myself.

koppor pushed a commit to JabRef/JabRef-Browser-Extension-experimental that referenced this pull request Aug 12, 2026
* main: (21 commits)
  fix: Chrome native messaging (#700)
  docs: add git submodule hint (#697)
  chore: add .idea to .gitignore (#698)
  chore(deps): update dependency oxfmt to v0.61.0 (#709)
  chore(deps): update dependency vue-tsc to v3.3.8 (#705)
  chore(deps): update tailwindcss monorepo to v4.3.3 (#707)
  chore(deps): update dependency globals to v17.9.0 (#719)
  chore(deps): update dependency node to v24.19.0 (#718)
  chore(deps): update dependency wxt to v0.21.3 (#717)
  chore(deps): update pnpm/action-setup action to v6.0.10 (#716)
  chore(deps): update github-actions to v7 (#715)
  chore(deps): update dependency globals to v17.8.0 (#708)
  chore(deps): update pnpm to v10.34.5 (#706)
  chore(deps): update dependency vue to v3.5.40 (#704)
  chore(deps): update dependency vitest to v4.1.10 (#703)
  chore(deps): update dependency oxlint to v1.76.0 (#710)
  chore(deps): update dependency typescript to v7 (#714)
  chore(deps): update dependency jsdom to v30 (#713)
  chore(deps): update github-actions (#712)
  chore(deps): update dependency wxt to v0.21.2 (#711)
  ...
koppor pushed a commit to JabRef/JabRef-Browser-Extension-experimental that referenced this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants