fix: limit Chrome-only permissions to non-Firefox browsers - #696
fix: limit Chrome-only permissions to non-Firefox browsers#696ryan-carpenter wants to merge 4 commits into
Conversation
…ons `key` and `offscreen` to non-Firefox builds.
| "downloads", | ||
| "webRequest", | ||
| "declarativeNetRequest", | ||
| ...(browser !== "firefox" ? ["offscreen"] : []), |
There was a problem hiding this comment.
might want to change this to "browser == chrome => offscreen included". But for now that's okay.
There was a problem hiding this comment.
Claude originally suggested browser === 'chrome' ? ['offscreen'] and browser === "chrome" || browser === "edge" || browser === "opera" ? ["offscreen"].
I reversed this and excluded Firefox, to grant the permission to chromium-based browsers without listing them explicitly. Failing to provide permission to a chromium browser could break functionality, whereas granting permission to a Firefox/Gecko browser only produces a warning that users don't see. Firefox can't use the permission in any case, so if the extension depends on this, it has to be provided another way.
|
CI fails now with a strange I don't understand this and sadly don't have time right now to investigate further. Will look at it again hopefully at the end of next week. |
|
|
|
github secrets are not available on forks, that's why CI is failing |
Closes #695 by removing a redundant permission and limiting Chrome-only permissions to non-Firefox builds. Claude.ai suggested changes, I inspected, implemented, and tested in Firefox. The manifest warnings were resolved. I have not tested in Chrome.