fix(review): hold standalone provider-file edits for manual review

[bitfathers94]

fix(review): hold standalone provider-file edits for manual review

runSurfaceReview's standalone provider path only ever read the file at
head, so editing an already-registered registry/providers/.json
outside a companion PR auto-merged or auto-closed off document validity
alone, even though the identical edit riding alongside an entry file was
already held for a human by the companion guard. Read head and base
concurrently and apply the same non-null-base check the companion path
uses, routing edits to manual review while leaving genuine debut
submissions (null base) on the existing merge/close path.

Closes #9666

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-29 22:49:36 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This closes a real gap: the standalone provider path only ever read head and never checked base, so an edit to an already-registered provider file (no companion entry) could auto-merge/close like a debut, unlike the identical edit riding alongside an entry file which was already gated. The fix mirrors the existing companion-path pattern exactly (non-null base -> manual), fetches head/base concurrently via Promise.all, and is well covered by new tests for the edit case, the debut case, and the no-validator short-circuit ordering. The diff is small, targeted, and directly traceable to issue #9666.

Nits — 2 non-blocking

• orchestrator.ts:334-337 duplicates the NON_DEBUT_COMPANION_SUMMARY logic/comment that also appears later for the companion-provider case — consider extracting a small shared helper (e.g. `isNonDebutEdit(baseRaw)`) to keep the two checks from drifting apart, though as written they're small enough that this is optional.
• Consider factoring the repeated `baseRaw !== null` debut-check + NON_DEBUT_COMPANION_SUMMARY return into a tiny shared helper used by both the standalone and companion-provider branches in orchestrator.ts.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#9666
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	⚠️ 20/25	Preflight is ready, but the PR body does not name the validation run.
Contributor workload	✅ 10/10	Author activity: 101 registered-repo PR(s), 69 merged, 1 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bitfathers94; Gittensor profile; 101 PR(s), 1 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff adds the concurrent head/base Promise.all read to the standalone provider branch and returns the identical manual verdict with NON_DEBUT_COMPANION_SUMMARY when base is non-null, exactly matching the required pattern, and includes named regression tests for the edit case, the null-base merge/close non-regression case, the concurrent-fetch assertion, and the zero-loadFile no-validator short

Review context

• Author: bitfathers94
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: TypeScript
• Official Gittensor activity: 101 PR(s), 1 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Add validation command/output.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.55%. Comparing base (1e1b004) to head (cfe3686).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9917      +/-   ##
==========================================
+ Coverage   79.52%   79.55%   +0.03%     
==========================================
  Files         281      282       +1     
  Lines       58577    58681     +104     
  Branches     6833     6870      +37     
==========================================
+ Hits        46581    46685     +104     
  Misses      11706    11706              
  Partials      290      290              

Flag	Coverage Δ
backend	100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/review/content-lane/orchestrator.ts	100.00% <100.00%> (ø)