fix(orb): wire the config-drift recap section into the maintainer digest - #9910
Conversation
buildDriftRecapSection had no production caller: runMaintainerRecap never sourced a DriftRecapSection, so the digest never rendered a Config drift section even once the sentinel started persisting fingerprint rows. Add a private loadDriftRecapSection loader (mirroring loadRoutingRecapSection's fail-safe shape) that reads isConfigDriftSentinelEnabled plus the live knob statuses and a single bounded system_flags LIKE query for fingerprint timestamps, and wire it into runMaintainerRecap. A caller-supplied options.configDrift still overrides the loaded one.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-29 21:57:07 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9910 +/- ##
==========================================
+ Coverage 79.52% 79.62% +0.10%
==========================================
Files 281 283 +2
Lines 58577 58885 +308
Branches 6833 6924 +91
==========================================
+ Hits 46581 46888 +307
Misses 11706 11706
- Partials 290 291 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix(orb): wire the config-drift recap section into the maintainer digest
buildDriftRecapSection had no production caller: runMaintainerRecap never
sourced a DriftRecapSection, so the digest never rendered a Config drift
section even once the sentinel started persisting fingerprint rows.
Add a private loadDriftRecapSection loader (mirroring loadRoutingRecapSection's
fail-safe shape) that reads isConfigDriftSentinelEnabled plus the live knob
statuses and a single bounded system_flags LIKE query for fingerprint
timestamps, and wire it into runMaintainerRecap. A caller-supplied
options.configDrift still overrides the loaded one.
Closes #9698