fix(ci): unbreak main — drop the unused MCP_SERVER_NAME export - #10195
Merged
Conversation
dead-exports:check, part of test:ci, is red on a clean main, so every open PR inherits the failure and none can go green. Third instance of this class after #9944 and #10109. #10177 added `export const MCP_SERVER_NAME` in src/mcp/server.ts. Both readers live in that same file -- the handshake's serverInfo.name and the analytics property builder -- so the export has no consumer. CHAT_GROUNDING_MCP_SERVER_NAME in the engine is a separate symbol, not this one re-exported. No behaviour change: the constant and both call sites are untouched, and its "one constant so the handshake and the dashboards cannot disagree" rationale still holds. It is simply module-local now. Closes #10194
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
1 similar comment
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10194
dead-exports:check— part oftest:ci— is red on a cleanmain:Every open PR inherits this, so nothing can go green until it lands. Third instance of this class (#9944, #10109).
Cause
#10177 added
export const MCP_SERVER_NAME = "loopover"atsrc/mcp/server.ts:843. Both readers are in that same file —serverInfo.name(line 863) and the analytics property builder (line 679).Checked for a cross-package reader before removing it:
CHAT_GROUNDING_MCP_SERVER_NAMEinpackages/loopover-engineis a separate symbol, not this one re-exported.Change
Drop the
export. The constant, both call sites, and its rationale (one constant so the handshake a client sees and the dashboards an operator reads cannot disagree) are all unchanged — it is simply module-local.Verification
typecheckclean ·dead-exports:checkgreen · 1,339 MCP tests pass.Follow-up worth considering
Three times now a merged PR has left
mainred on this checker, each time blocking the queue until someone noticed. #10146's escalation covers a workflow red across consecutive runs, but this is a different signal: the PR was green when it merged. Worth understanding why a merge can turn this red when the PR wasn't — noted in the issue.