Skip to content

fix(ci): unbreak main — drop the unused MCP_SERVER_NAME export - #10195

Merged
JSONbored merged 1 commit into
mainfrom
fix/unbreak-main-mcp-server-name
Jul 31, 2026
Merged

fix(ci): unbreak main — drop the unused MCP_SERVER_NAME export#10195
JSONbored merged 1 commit into
mainfrom
fix/unbreak-main-mcp-server-name

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Closes #10194

dead-exports:check — part of test:ci — is red on a clean main:

check-dead-exports found 1 exported symbol(s) with no reference outside their own file:
  src/mcp/server.ts: MCP_SERVER_NAME (used internally — drop the `export` keyword)

Every open PR inherits this, so nothing can go green until it lands. Third instance of this class (#9944, #10109).

Cause

#10177 added export const MCP_SERVER_NAME = "loopover" at src/mcp/server.ts:843. Both readers are in that same file — serverInfo.name (line 863) and the analytics property builder (line 679).

Checked for a cross-package reader before removing it: CHAT_GROUNDING_MCP_SERVER_NAME in packages/loopover-engine is a separate symbol, not this one re-exported.

Change

Drop the export. The constant, both call sites, and its rationale (one constant so the handshake a client sees and the dashboards an operator reads cannot disagree) are all unchanged — it is simply module-local.

Verification

typecheck clean · dead-exports:check green · 1,339 MCP tests pass.

Follow-up worth considering

Three times now a merged PR has left main red on this checker, each time blocking the queue until someone noticed. #10146's escalation covers a workflow red across consecutive runs, but this is a different signal: the PR was green when it merged. Worth understanding why a merge can turn this red when the PR wasn't — noted in the issue.

dead-exports:check, part of test:ci, is red on a clean main, so every open PR
inherits the failure and none can go green. Third instance of this class after
#9944 and #10109.

#10177 added `export const MCP_SERVER_NAME` in src/mcp/server.ts. Both readers
live in that same file -- the handshake's serverInfo.name and the analytics
property builder -- so the export has no consumer. CHAT_GROUNDING_MCP_SERVER_NAME
in the engine is a separate symbol, not this one re-exported.

No behaviour change: the constant and both call sites are untouched, and its
"one constant so the handshake and the dashboards cannot disagree" rationale
still holds. It is simply module-local now.

Closes #10194
@loopover-orb

loopover-orb Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏳ LoopOver is waiting…

LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

1 similar comment
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored
JSONbored merged commit b4c984e into main Jul 31, 2026
2 checks passed
@JSONbored
JSONbored deleted the fix/unbreak-main-mcp-server-name branch July 31, 2026 12:03
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
25852 1 25851 21
View the top 1 failed test(s) by shortest run time
test/integration/api.test.ts > api routes > serves private MCP tool listing and tool calls
Stack Traces | 0.678s run time
AssertionError: expected 500 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 500

 ❯ test/integration/api.test.ts:5098:44

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: dead-exports:check red on a clean main again — MCP_SERVER_NAME from #10177

1 participant