fix(ui-kit): expose PaginationEllipsis More pages outside aria-hidden - #10136
Conversation
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 08:58:59 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy · Diff highlights exactly what changed. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Move aria-hidden from the ellipsis wrapper onto the decorative icon so the sr-only label stays in the accessibility tree. Closes JSONbored#10052 Co-authored-by: Cursor <cursoragent@cursor.com>



Summary
aria-hiddenfromPaginationEllipsis's outer span onto the decorativeMoreHorizontalicon so thesr-only"More pages" label is announced.{...props}last so an explicit calleraria-hiddenstill wins.Closes #10052
Test plan
npm --workspace @loopover/ui-kit run test -- src/components/pagination.test.tsx(6 pass)