Skip to content

fix(ui-kit): expose PaginationEllipsis More pages outside aria-hidden - #10136

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/ui-kit-pagination-ellipsis-a11y-10052
Jul 31, 2026
Merged

fix(ui-kit): expose PaginationEllipsis More pages outside aria-hidden#10136
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/ui-kit-pagination-ellipsis-a11y-10052

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Move aria-hidden from PaginationEllipsis's outer span onto the decorative MoreHorizontal icon so the sr-only "More pages" label is announced.
  • Mirror the TypingIndicator pattern; keep {...props} last so an explicit caller aria-hidden still wins.

Closes #10052

Test plan

  • npm --workspace @loopover/ui-kit run test -- src/components/pagination.test.tsx (6 pass)
  • Label has no aria-hidden ancestor; icon is aria-hidden
  • className merge + props override covered

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 31, 2026 08:49
@loopover-orb

loopover-orb Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-31 08:58:59 UTC

2 files · 1 AI reviewer · no blockers · readiness 86/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR correctly relocates aria-hidden from the outer wrapper span to the decorative MoreHorizontal icon in PaginationEllipsis, which un-hides the sr-only "More pages" text from the accessibility tree — matching the stated TypingIndicator pattern. The change is minimal, matches the described intent, and is covered by three new tests verifying the label's a11y-tree exposure, className merging, and that an explicit caller aria-hidden prop still wins via {...props} ordering. CI passed on this commit and the fix is traceable end-to-end with no unreachable branches.

Nits — 4 non-blocking
  • The sibling BreadcrumbEllipsis in breadcrumb.tsx has the identical bug (aria-hidden on the outer span hides the sr-only "More" label) but is untouched by this PR — worth a follow-up issue if not already filed.
  • pagination.tsx: PaginationEllipsis lacks role="presentation" that BreadcrumbEllipsis has on its outer span; not introduced by this diff, but worth confirming it's intentional for parity.
  • Consider filing/linking a follow-up issue for the same aria-hidden-wraps-sr-only-label pattern in breadcrumb.tsx's BreadcrumbEllipsis, since it appears to have the same defect.
  • In pagination.test.tsx, the query `container.querySelector("svg")` assumes a single icon in the tree — fine today but consider scoping via a data-testid if PaginationEllipsis ever renders additional svgs.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #10052
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 239 registered-repo PR(s), 89 merged, 38 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 239 PR(s), 38 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff moves aria-hidden from the outer span onto the MoreHorizontal icon, matching the TypingIndicator pattern, and adds tests in pagination.test.tsx covering the no-aria-hidden-ancestor label, the className merge, and the caller aria-hidden override, satisfying the stated deliverables.

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 239 PR(s), 38 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add a concise scope and risk note.
  • Then work through the remaining 1 step in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
diff /
diff /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy · Diff highlights exactly what changed.

Scroll preview
Route Before (production) After (this PR's preview)
/ before / (scroll)
before / (scroll)
after / (scroll)
after / (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Move aria-hidden from the ellipsis wrapper onto the decorative icon so
the sr-only label stays in the accessibility tree.

Closes JSONbored#10052

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 31, 2026

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 291fcd9 into JSONbored:main Jul 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui-kit(pagination): PaginationEllipsis's "More pages" sr-only label sits inside an aria-hidden subtree, so it is never announced

2 participants