feat(review): add review.visual.enabled config-as-code toggle#4093
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | c9f4fcc | Commit Preview URL Branch Preview URL |
Jul 08 2026, 12:49 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4093 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 384 384
Lines 35853 35856 +3
Branches 13157 13159 +2
=======================================
+ Hits 33574 33579 +5
Misses 1618 1618
+ Partials 661 659 -2
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 01:03:46 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
1a6140d to
9e5c5ec
Compare
Lets an operator turn visual-capture on/off per-repo (or set a global default) purely through .gittensory.yml, without touching the shared GITTENSORY_REVIEW_SCREENSHOTS / GITTENSORY_REVIEW_REPOS env-var gate used by every other converged feature.
…alse path Use a sentinel no-routes/non-pending capture result instead of wrapping the existing buildCapture + self-poll block in a new if, so the diff only touches the actual gating line -- codecov/patch was counting the purely-reindented, already-covered lines as new patch surface.
The reindentation from the enabled:false ternary dragged these pre-existing optional spreads into the diff; codecov/patch correctly flagged them as needing fresh branch coverage even though the logic itself is unchanged.
9e5c5ec to
c9f4fcc
Compare
Summary
review.visual.enabled(boolean, default unset/null) to the existingVisualConfigtype, resolved through the standard 3-layer config-as-code precedence (per-repo file > global-default file >_sharedfile) already used byreview.visual.preview/routes/themes/gif.GITTENSORY_REVIEW_SCREENSHOTS+GITTENSORY_REVIEW_REPOSgate (byte-identical to today); explicitfalse(global default, or overridden per-repo) forces visual capture off for that repo even when the env-var gate would otherwise allow it; explicittrueopts a repo back in at a layer where a broader default disabled it..gittensory.ymlon their own VPS — no redeploy needed — closing part of Epic: config-as-code should fully control every review feature, not just restrict it #4092 (config-as-code should fully control every review feature).Closes #4083. Part of #4092.
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run test:ci— full local gate, green: 580 test files / 11670 tests passed, 0 failures.npm run typecheck— clean.npm audit --audit-level=moderateSafety
.gittensory.yml.example+config/examples/gittensory.full.yml, kept in sync).