Skip to content

Feat: Simplify, with token becomes where token in match - #495

Merged
JSAbrahams merged 2 commits into
developfrom
feat-remove-with-token
Aug 28, 2026
Merged

Feat: Simplify, with token becomes where token in match#495
JSAbrahams merged 2 commits into
developfrom
feat-remove-with-token

Conversation

@JSAbrahams

Copy link
Copy Markdown
Owner

Summary

With did almost the same, lets simplify the language. This makes more clear that 'do' is for imperative, and where is for those places where the order does not matter.

Added Tests

Tests update to reflect the change.

With did almost the same, lets simplify the language.
This makes more clear that 'do' is for imperative, and where
is for those places where the order does not matter.
@JSAbrahams JSAbrahams self-assigned this Aug 28, 2026
@JSAbrahams JSAbrahams added documentation Update or fix documentation enhancement: parse New feature in the parse module labels Aug 28, 2026
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:12 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:12 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:12 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:12 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:12 — with GitHub Actions Active
@JSAbrahams JSAbrahams changed the title Feat: Simplify, with token becomes where token Feat: Simplify, with token becomes where token in match Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.50%. Comparing base (8155000) to head (c5dff29).

Files with missing lines Patch % Lines
src/backend/python/convert/mod.rs 87.50% 1 Missing ⚠️
src/parse/ast/node.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #495   +/-   ##
========================================
  Coverage    92.50%   92.50%           
========================================
  Files          113      113           
  Lines        15709    15709           
========================================
  Hits         14531    14531           
  Misses        1178     1178           
Files with missing lines Coverage Δ
src/check/ast/mod.rs 100.00% <ø> (ø)
src/check/ast/node.rs 99.16% <ø> (ø)
src/check/constrain/generate/mod.rs 93.84% <100.00%> (ø)
src/check/constrain/generate/resources.rs 96.55% <100.00%> (ø)
src/parse/ast/mod.rs 85.29% <ø> (ø)
src/parse/control_flow_expr.rs 93.12% <100.00%> (ø)
src/parse/lex/token.rs 85.62% <100.00%> (ø)
src/parse/lex/tokenize.rs 98.80% <100.00%> (ø)
src/parse/statement.rs 94.92% <100.00%> (ø)
src/backend/python/convert/mod.rs 95.47% <87.50%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:30 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:30 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:30 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:30 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 28, 2026 09:30 — with GitHub Actions Active
@JSAbrahams
JSAbrahams merged commit c8e96a6 into develop Aug 28, 2026
6 checks passed
@JSAbrahams
JSAbrahams deleted the feat-remove-with-token branch August 28, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Update or fix documentation enhancement: parse New feature in the parse module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant