Feat: Simplify, with token becomes where token in match - #495
Merged
Conversation
With did almost the same, lets simplify the language. This makes more clear that 'do' is for imperative, and where is for those places where the order does not matter.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #495 +/- ##
========================================
Coverage 92.50% 92.50%
========================================
Files 113 113
Lines 15709 15709
========================================
Hits 14531 14531
Misses 1178 1178
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With did almost the same, lets simplify the language. This makes more clear that 'do' is for imperative, and where is for those places where the order does not matter.
Added Tests
Tests update to reflect the change.