Skip to content

Test: Cover a few hidden branches - #491

Merged
JSAbrahams merged 10 commits into
developfrom
feat-cover-more-branches
Aug 25, 2026
Merged

Test: Cover a few hidden branches#491
JSAbrahams merged 10 commits into
developfrom
feat-cover-more-branches

Conversation

@JSAbrahams

@JSAbrahams JSAbrahams commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Features

  • Internal python primitives' method's marked as pure always.
  • During testing we uncovered a bug where types were incorrectly assigned for defaults of function arguments.

Added Tests

  • See added tests

@JSAbrahams JSAbrahams self-assigned this Aug 25, 2026
@JSAbrahams JSAbrahams added enhancement: check New feature in the type check module test: check Tests for the type checker labels Aug 25, 2026
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:17 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:17 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:17 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:17 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:17 — with GitHub Actions Active
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.73%. Comparing base (3c0b01c) to head (93cfddd).

Files with missing lines Patch % Lines
src/check/context/arg/generic.rs 90.90% 1 Missing ⚠️
src/check/context/field/generic.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #491      +/-   ##
===========================================
+ Coverage    88.91%   90.73%   +1.82%     
===========================================
  Files          104      103       -1     
  Lines        15028    14746     -282     
===========================================
+ Hits         13362    13380      +18     
+ Misses        1666     1366     -300     
Files with missing lines Coverage Δ
src/check/ast/mod.rs 100.00% <ø> (ø)
src/check/ast/node.rs 99.20% <ø> (+5.28%) ⬆️
src/check/constrain/generate/mod.rs 95.38% <ø> (+1.44%) ⬆️
src/check/constrain/generate/operation.rs 96.87% <ø> (+8.35%) ⬆️
src/check/context/clss/generic.rs 95.28% <100.00%> (+2.42%) ⬆️
src/check/context/clss/python.rs 89.41% <100.00%> (ø)
src/check/context/function/generic.rs 99.10% <100.00%> (+6.31%) ⬆️
src/check/context/function/mod.rs 41.90% <ø> (ø)
src/check/context/parameter/generic.rs 100.00% <100.00%> (+100.00%) ⬆️
src/check/context/parameter/python.rs 80.95% <ø> (+32.38%) ⬆️
... and 13 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Joel Abrahams added 5 commits August 25, 2026 15:20
@JSAbrahams
JSAbrahams force-pushed the feat-cover-more-branches branch from 7b20013 to f8590a6 Compare August 25, 2026 13:46
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:46 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:46 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:46 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:46 — with GitHub Actions Active
@JSAbrahams
JSAbrahams deployed to development August 25, 2026 13:46 — with GitHub Actions Active
@JSAbrahams
JSAbrahams merged commit aa8541d into develop Aug 25, 2026
6 checks passed
@JSAbrahams
JSAbrahams deleted the feat-cover-more-branches branch August 25, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement: check New feature in the type check module test: check Tests for the type checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant