Repository navigation
fix: integrate chat, recording and restart persistence with current main - #25
Merged
Merged
Conversation
YueyuHoshizora
marked this pull request as ready for review
October 21, 2026 12:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
延續已關閉的 #23，將原功能分支正常合併最新 main（ec7e2cf），解決 12 個檔案衝突，保留 main 的協商 ownership、取消安全、停機排空、品質回報與 UI 行為。
修復原五項審查發現：
新增重新啟動、production saver、設定相容性及實際 Opus 編解碼回歸。舊設定省略新欄位時可繼續啟動；錄音與持久化仍預設停用。舊分支整體改寫 SDK 錯誤文字的做法不移植，沿用 main 既有錯誤契約與 UI 提示。
本機 Node 24.22.0：typecheck 通過；伺服器／整合測試 4171 pass、10 平台限定 skip；SDK 2662 pass；build（含 client package）通過；真實 werift-loopback 0、2（含錄音、重協商、ICE restart）通過；npm ci audit 0 vulnerabilities；git diff --check 通過。Repository 無 lint script。最新提交 9428629 的 PR CI 與 push CI 均成功，包含 Ubuntu server delivery 與原生 Windows PowerShell 啟動檢查。未 force push、未刪分支、未修改 CI／保護規則。