Android: auto-hide the on-screen menu button, and open the menu with Back/Select#249
Open
RakugaKid wants to merge 1 commit into
Open
Android: auto-hide the on-screen menu button, and open the menu with Back/Select#249RakugaKid wants to merge 1 commit into
RakugaKid wants to merge 1 commit into
Conversation
…Back/Select TouchOverlay: the whole on-screen overlay (stick, face buttons, and the menu hamburger) now hides whenever a physical controller is connected, via a single unified visibility rule. Touch-only users are unaffected; the overlay returns when no pad is present. BattleShipActivity: the Android Back button and gamepad Select now toggle the libultraship menu (dispatchKeyEvent -> the existing menu-toggle path), so the menu stays reachable once the hamburger is hidden. Tested on an Odin 2 Mini. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First-time contributor here! Opening this as a proposal, happy to adjust anything or close it if it doesn't fit. 🙂
What
On Android the on-screen menu (hamburger) button was always visible, awkward on handhelds like the Odin 2 that play with a built-in gamepad.
dispatchKeyEvent→ the existing menu-toggle path), so it stays reachable once the hamburger is hidden.Why
With a controller connected the hamburger was redundant clutter, and hiding only the gameplay buttons (previous behaviour) left no way to reach the menu without touching the screen.
Testing
Built and ran on an Odin 2 Mini: overlay hides with the built-in pad, Back and Select open/close the menu, and touch-only mode (no pad) still shows/uses the hamburger.