on MacOS using osascript instead of tk to avoid crash - #6
Open
bpstudio wants to merge 1 commit into
Open
Conversation
|
@JRYCodesYT Create a new branch, for example |
Author
|
@JRYCodesYT @GeorgiosPapadakis yes, if there is a develop branch, I can modify the PRs to merge to there. |
|
@bpstudio Yes @JRYCodesYT must handle that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Save, Load, and audio import currently create and destroy a new Tk root on every click. On macOS that conflicts with Pygame/SDL's Cocoa
NSApplicationsingleton, so the file picker hangs or crashes.This change:
osascripton DarwinOn Windows/Linux: Save, Load, and audio import still open the Tk file picker