-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] auth-api 연동 — Passport 인증 필터 추가 및 자체 OAuth2 서버 제거 #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kmando01
wants to merge
14
commits into
develop
Choose a base branch
from
SM/feat/auth-api-passport-integration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
198affd
refactor(auth): remove EEOS custom OAuth2 server, delegate client reg…
e4577dc
feat(auth): add PassportAuthenticationFilter for Gateway JWT Passport…
6a9852e
test(security): PassportAuthenticationFilter 단위 테스트 추가
de0e6db
refactor: AccessTokenFilter 제거 — 구형 EEOS 토큰 하위 호환 경로 삭제
kmando01 f048efc
test: AccessTokenFilterTest 제거
kmando01 287be04
refactor: SecurityFilterChainConfig에서 AccessTokenFilter 제거
kmando01 e2d725f
refactor: MemberArgumentResolver에서 구형 토큰 fallback 제거
kmando01 0a03630
fix: SecurityConfig에서 AccessTokenFilter 빈 등록 제거
kmando01 650d4ec
fix: Passport roles에 ROLE_ 접두사 추가 (Spring Security hasAnyRole 호환)
kmando01 5a4159d
test: SpringSecurityFilterChainTest를 X-User-Passport 방식으로 전환
kmando01 4b4b8b2
style: Spotless 포맷 수정 (Javadoc 줄바꿈)
kmando01 abe7e8f
style: Spotless 포맷 수정 (메서드 체인 줄바꿈)
kmando01 b4d7cb2
style: Javadoc 한 줄로 합쳐 Spotless 통과
kmando01 0327284
test: PassportAuthenticationFilterTest 기대값을 ROLE_ 접두사 포함으로 수정
kmando01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
eeos/src/main/java/com/blackcompany/eeos/auth/application/domain/AuthorizationCodeData.java
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
eeos/src/main/java/com/blackcompany/eeos/auth/application/domain/ClientType.java
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
eeos/src/main/java/com/blackcompany/eeos/auth/application/domain/PkceValidator.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
...in/java/com/blackcompany/eeos/auth/application/dto/request/ClientRegistrationRequest.java
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
.../java/com/blackcompany/eeos/auth/application/dto/response/ClientRegistrationResponse.java
This file was deleted.
Oops, something went wrong.
90 changes: 0 additions & 90 deletions
90
eeos/src/main/java/com/blackcompany/eeos/auth/application/service/ClientService.java
This file was deleted.
Oops, something went wrong.
69 changes: 0 additions & 69 deletions
69
eeos/src/main/java/com/blackcompany/eeos/auth/application/service/OAuth2LoginService.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서 예시에 시크릿 형태 값 노출을 피해주세요.
Line 175의
clientSecret값은 실제 키 여부와 무관하게 비밀정보 탐지 규칙을 트리거할 수 있습니다. 플레이스홀더(예:<issued-once-secret>)로 바꾸는 편이 안전합니다.🔧 제안 변경
📝 Committable suggestion
🧰 Tools
🪛 Betterleaks (1.3.1)
[high] 175-175: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
🤖 Prompt for AI Agents