Repository navigation
🐛 fix(sandbox): fix large attachment transfering between host and container - #34
Merged
Merged
Conversation
…tainer Chunk file transfers above 32 MiB so base64 payloads stay far below the V8 string limit (0x1fffffe8 chars); attachments over ~384 MiB previously crashed Solver creation with \"Cannot create a string longer than 0x1fffffe8 characters\". Large replaceFile stays atomic via staged temp file + rename. Attachment unchanged-check now compares size + SHA-256 instead of reading the whole file back (readBinaryFile is capped by the 8 MiB exec output limit, so files >= 6 MiB were always rewritten).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk file transfers above 32 MiB so base64 payloads stay far below the V8 string limit (0x1fffffe8 chars); attachments over ~384 MiB previously crashed Solver creation with "Cannot create a string longer than 0x1fffffe8 characters". Large replaceFile stays atomic via staged temp file + rename. Attachment unchanged-check now compares size + SHA-256 instead of reading the whole file back (readBinaryFile is capped by the 8 MiB exec output limit, so files >= 6 MiB were always rewritten).