Skip to content

🐛 fix(ci): stabilize model tests and image builds - #33

Merged
nick-cjyx9 merged 2 commits into
mainfrom
codex/fix-model-pool-browser-test
Aug 20, 2026
Merged

nick-cjyx9 merged 2 commits into
mainfrom
codex/fix-model-pool-browser-test

Conversation

@gubaiovo

@gubaiovo gubaiovo commented Aug 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • replace Iconify with a deterministic test double in the model pool component suite
  • prevent Iconify browser timers from updating React after jsdom teardown
  • copy the Shellpoop workspace manifest in both Docker dependency stages so the latest main can build
  • retain all model discovery, add, delete, rebinding, and crypto fallback behavior assertions

Test Doctor audit

The icon loader is an external browser rendering boundary, not part of the model pool contract. Mocking it removes nondeterministic timer work without mocking model pool state or API behavior.

Validation

  • corepack pnpm exec vp check (0 errors; 1 pre-existing shellpoop warning)
  • corepack pnpm exec vp run typecheck
  • corepack pnpm exec vp test run apps/frontend/test/model-pool-editor.test.ts (6 passed)
  • corepack pnpm exec vp test (244 files passed; 1504 passed, 101 skipped)
  • corepack pnpm exec vp build
  • remote docker build --check and image build are part of deployment verification

Copilot AI lite review requested due to automatic review settings August 20, 2026 03:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gubaiovo gubaiovo changed the title 🧪 test(webui): isolate model pool icons 🐛 fix(ci): stabilize model tests and image builds Aug 20, 2026
@nick-cjyx9
nick-cjyx9 merged commit c898613 into main Aug 20, 2026
2 checks passed
fressive pushed a commit that referenced this pull request Aug 21, 2026
* 🧪 test(webui): isolate model pool icons

* 🐛 fix(docker): install shellpoop workspace dependencies
@gubaiovo
gubaiovo deleted the codex/fix-model-pool-browser-test branch August 21, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants