Remove Inklecate from UnrealEngine Marketplace#154
Merged
Conversation
FAB now forbids bundling executables inside a plugin, so we need an alternataive
…CATE also skip pypi release if a +UEPatch is part of the version tag
Ink Proof ResultsThese results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since FAB no longer allows bundling executables, Inklecate cannot be shipped directly. Therefore, the UE plugin build does now respect
INKCPP_INKLCATE, if this is set toNONEno Inklecate will be bundled.Also, a setting in
Project Settings > Plugins > InkCPP > Inklecate Executable Pathwas added to set the path to the local inklecate executable. This setting is autofilled if Inklecate is bundled with the plugin (e.g., a local plugin build)Trying to import a
.inkfile while no Inklecate instance can be found opens a dialog that prompts to install Inklecate, offers a download link for the platform-relevant version, and provides a shortcut to the setting.