You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cette PR corrige une erreur de démarrage (BeanCreationException) sur l'environnement Render.
Le backend ne parvenait pas à s'initialiser car certaines propriétés injectées par @Value dans AuthenticationService.java étaient manquantes ou mal nommées dans le fichier application-prod.yml.
🛠️ Changements effectués
application-prod.yml
Renommage de reset-password-url en reset-url (pour correspondre au code).
Ajout de la propriété manquante add-url.
Harmonisation de la structure avec les environnements dev et local.
Summary by CodeRabbit
Chores
Updated mail configuration keys in the production environment.
Configuration key renamed in production settings: reset-password-url is now reset-url, and a new add-url key is introduced under the frontend mailing section. This affects how password reset and new password addition URLs are referenced by the application.
Changes
Cohort / File(s)
Summary
Production Configuration book-network/src/main/resources/application-prod.yml
Renamed application.mailing.frontend.reset-password-url to reset-url and added new add-url key in the same section.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
PR #6: Originally introduced the reset-password-url configuration key that is now being renamed and enhanced with the add-url addition in this PR.
Poem
🐰 Hop-hop, keys take flight, Reset becomes simpler, add shines bright, Config files dance in prod's delight, URLs reorganized just right! 🔑✨
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title is related to the main change, indicating a fix to mailing configuration in production, which directly corresponds to the configuration changes in application-prod.yml.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/mailing-config-prod
No actionable comments were generated in the recent review. 🎉
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Cette PR corrige une erreur de démarrage (BeanCreationException) sur l'environnement Render.
Le backend ne parvenait pas à s'initialiser car certaines propriétés injectées par
@ValuedansAuthenticationService.javaétaient manquantes ou mal nommées dans le fichierapplication-prod.yml.🛠️ Changements effectués
application-prod.ymlreset-password-urlenreset-url(pour correspondre au code).add-url.Summary by CodeRabbit