Extend Smart Contract: Comprehensive Lottery Round Details Tracking - #3
Open
pneppl100 wants to merge 8 commits into
Conversation
pneppl100
marked this pull request as ready for review
June 12, 2025 03:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend Smart Contract: Comprehensive Lottery Round Details Tracking
Description
Task
Extend Smart Contract to Store Additional Lottery Round Details
Acceptance Criteria
Summary of Work
This pull request implements an enhanced tracking mechanism for lottery round details in the smart contract, providing more comprehensive historical data for each lottery round.
Key Modifications:
LotteryRoundstruct to capture detailed round informationlotteryRoundsmapping to store round details permanentlygetLotteryRoundDetails()method for retrieving round informationfinishPickingWinner()to populate round details automaticallyDetailed Changes:
Created
LotteryRoundstruct with fields:Added new mapping:
mapping(uint256 => LotteryRound) public lotteryRoundsModified
finishPickingWinner()to store comprehensive round details when a winner is selectedAdded
getLotteryRoundDetails(uint256 _roundId)view function to retrieve round informationBenefits:
No breaking changes to existing contract functionality.
Changes Made
Tests
Signatures
Staking Key
5anfGeJtxL1qzX2vgQFqx4M5CkDLgfref2Dm4Stm4gP2: MZZGxynhQXqzo2ceFGfjKtjDLX8Phz6hjnwH31iyhhRP35eiJVDJPVyqvDM9sk4u8bnLvrUHo2LvwuY71C1mpMwWerpswf1GmgVsZgGKi9AWAVMNXJ91vzthDkXrwkCa923LUnXj45ocMqn2Lc8iARpEVH3CHAgnzzeeWKf2CoTWTUpgs4TxCVWtBCLp6zGArqb9JmQtMF2xu4s8kfBUyrnneMvpzeVyHLdN1FrYcFJDQ4K7x1JKsk1t6hGcc8icHj52YGCfcq5fDkkPSFhepizgSP6L1FhvyD3zegTeGnRzAradhbmxeMWbXKS7CYZzPCsnX7bzKGcbxTeE6ty3rodoY67KqCTVfZ1b6KgdL31nfXTQGVDZ8AL5Y7Pxvfh5NrLvoqXkQXWs3yd2a2vfSSJvBht9NUze5i
Public Key
DA8gmhDZQJz7igNrrkkYXwfYGpWaPaa3ftPDHt2yyn2S: 2RWHpUszJFamo7mcBh6fmFxCSRAH5ruaD8qm9uN3hvHGKAcmtcZ8bApVexTmjTmfQQUorsDKKng7bY2G7sYQhLLvhB6oVXnAUSdA6VhVjUdHEBA1F8qvyEf5GWL1UsxhBiJCsm2545sXxFxxaUpz2R14KcRY8XMDZXetT6BpemizuRW6Tk64RTLMTsnwkCB7gTHwPwHGHRmzMCc2dCizWqV4ttGhbFHFQGeSc1Yai66XWd2wLzBBgDViUGtQcNKmrpng278yE1EUByv8k2n7ERSUAG1kLjXycWeoQP69FBekGjeQynZu8aBykQinDpp3sBC9UrcAbufukXjX2yzVrwAPL4hDVLPmGWxw6WEfz2rRP221GbSnhvWy7JqgBuuL9wxcWY6vQsg1ZibiSgbP6gnajUGuFxjfkg