Skip to content
This repository was archived by the owner on Mar 2, 2023. It is now read-only.

WIP - review architecture#192

Open
OxMarco wants to merge 1 commit into
masterfrom
architectural-review
Open

WIP - review architecture#192
OxMarco wants to merge 1 commit into
masterfrom
architectural-review

Conversation

@OxMarco

@OxMarco OxMarco commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@OxMarco OxMarco changed the title review architecture WIP - review architecture Oct 3, 2022
github-advanced-security[bot]
github-advanced-security AI found potential problems Oct 3, 2022
View reviewed changes
Comment thread contracts/strategies/BaseStrategy.sol Outdated
Comment on lines 271 to 281

Check warning

Code scanning / Slither

Reentrancy vulnerabilities

Reentrancy in BaseStrategy.securitisePosition(uint256,address) (contracts/strategies/BaseStrategy.sol#271-281): External calls: - IERC20(position.owedToken).safeTransferFrom(msg.sender,position.lender,position.principal + position.fees) (contracts/strategies/BaseStrategy.sol#279) State variables written after the call(s): - positions[positionID].lender = newLender (contracts/strategies/BaseStrategy.sol#280)
Comment thread contracts/interfaces/IInterestRateModel.sol
@@ -0,0 +1,22 @@
// SPDX-License-Identifier: BUSL-1.1
pragma solidity >=0.8.12;

Check warning

Code scanning / Slither

Incorrect versions of Solidity

Pragma version>=0.8.12 (contracts/interfaces/IInterestRateModel.sol#2) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
Comment thread contracts/interfaces/ISVGImageGenerator.sol
@@ -0,0 +1,16 @@
// SPDX-License-Identifier: BUSL-1.1
pragma solidity >=0.8.12;

Check warning

Code scanning / Slither

Incorrect versions of Solidity

Pragma version>=0.8.12 (contracts/interfaces/ISVGImageGenerator.sol#2) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
Comment thread contracts/strategies/InterestRateModel.sol
@@ -0,0 +1,53 @@
// SPDX-License-Identifier: BUSL-1.1
pragma solidity >=0.8.12;

Check warning

Code scanning / Slither

Incorrect versions of Solidity

Pragma version>=0.8.12 (contracts/strategies/InterestRateModel.sol#2) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
Comment thread contracts/strategies/InterestRateModel.sol
contract InterestRateModel is IInterestRateModel {
using GeneralMath for uint256;

uint256 public immutable MAX_RATE;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable InterestRateModel.MAX_RATE (contracts/strategies/InterestRateModel.sol#14) is not in mixedCase
Comment thread contracts/libraries/VaultMath.sol
uint24 internal constant MAX_RATE = 500;

uint256 internal constant DEGRADATION_COEFFICIENT = 21600; // six hours
uint24 internal constant TIME_FEE_WINDOW = 84600;

Check warning

Code scanning / Slither

Unused state variable

VaultMath.TIME_FEE_WINDOW (contracts/libraries/VaultMath.sol#14) is never used in VaultMath (contracts/libraries/VaultMath.sol#10-62)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OxMarco @github-advanced-security