Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK’s development and example app environment to React Native 0.85.3, refreshing the corresponding JS tooling and native build wrappers so the repo aligns with the new RN baseline.
Changes:
- Bump
react-native(and related@react-native/*tooling) to 0.85.3 across the workspace. - Switch Jest configuration to use the new standalone preset
@react-native/jest-preset. - Update example native tooling (iOS project references, Gradle wrapper scripts/version) and Ruby stdlib gem dependencies for newer Ruby versions.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Regenerated lockfile reflecting RN 0.85.3 and related dependency graph changes. |
| package.json | Pins RN + @react-native/* dev tooling to 0.85.3 and adds @react-native/jest-preset. |
| jest.config.js | Updates Jest preset to @react-native/jest-preset. |
| example/package.json | Updates example app RN/tooling versions to 0.85.3 and adds @react-native/jest-preset. |
| example/jest.config.js | Updates example Jest preset to @react-native/jest-preset. |
| example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj | Updates CocoaPods-generated file references/IDs after dependency upgrade. |
| example/Gemfile | Adds nkf gem (Ruby stdlib extraction compatibility). |
| example/android/gradlew.bat | Updates Gradle wrapper invocation style to java -jar .... |
| example/android/gradlew | Updates Gradle wrapper invocation style to java -jar ... and removes unused classpath handling. |
| example/android/gradle/wrapper/gradle-wrapper.properties | Bumps Gradle distribution to 9.3.1 for the example Android project. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Approved. Clean smoke on this branch — yarn install (root + example), bundle exec pod install, iOS xcodebuild, ./gradlew :app:assembleDebug (Gradle 9.3.1, Java 17, 189 tasks), yarn build/typecheck/lint/test (476).
Nit (P2): npm pack --dry-run fails here because prepare (package.json:48) shells out to global yarn, not the repo's pinned .yarn/releases/yarn-3.6.1.cjs. With --ignore-scripts it passes. If publish CI already provisions Corepack/Yarn this is moot; worth confirming before 4.0 cuts. Cleanest fix: switch prepare to node .yarn/releases/yarn-3.6.1.cjs build.
Nit: Tarball still includes 60 generated test artifacts (lib/module/**/*.test.js.map, lib/typescript/**/*.test.d.ts/.map). files excludes *.test.{js,ts,tsx} but not the generated .map/.d.ts. Pre-existing. Add !**/*.test.* to files before 4.0.

🔹 JIRA Ticket(s) if any
✏️ Description