Fix TaskModal lint failure by removing synchronous state update in effect - #1
Closed
Ishaan2510 with Copilot wants to merge 1 commit into
Closed
Fix TaskModal lint failure by removing synchronous state update in effect#1Ishaan2510 with Copilot wants to merge 1 commit into
Ishaan2510 with Copilot wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job lint
Fix TaskModal lint failure by removing synchronous state update in effect
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintGitHub Actions job failed due toreact-hooks/set-state-in-effectinTaskModal.jsx, where component state was being synchronously set inside an effect. This change removes that anti-pattern while preserving task-stream initialization behavior.Root cause addressed: TaskModal effect state sync
TaskModaltask-state initialization so it no longer callssetDetail(task)directly in theuseEffectbody that opens the EventSource stream.snapshot,progress,token,provider_switch,complete,error) intact.State flow cleanup
detailnow derives from the current task input/state transition pattern instead of being force-set synchronously at effect start.streamingResult, provider-switch banner, token buffer) remains coupled to task changes.