Fix CI workflow and remove duplicate method definitions - #61
Closed
mherman22 wants to merge 1 commit into
Closed
Conversation
- Update deprecated GitHub Actions: checkout v2→v4, setup-java v1→v4, cache v2→v4, setup-maven v4→v5 - Replace s4u/maven-settings-action with setup-java built-in server config - Remove duplicate getPatientList() definitions in MpiClientService, MpiClientWorker, and MpiClientServiceImpl that caused compile errors - Fix parseFhirPatient() call signature in FhirMpiClientServiceImpl
Author
CI failure is a pre-existing issueThe build fails because the This affects all fork PRs, not just this one — the The code compiles and all 21 tests pass locally: To fix CI for fork PRs, the workflow could use |
6 tasks
Author
|
Folded into #60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutv2 → v4actions/setup-javav1 → v4 (withtemurindistribution)actions/cachev2 → v4stCarolas/setup-mavenv4 → v5s4u/maven-settings-actionwithsetup-javabuilt-in Maven server configgetPatientList()method definitions inMpiClientService,MpiClientWorker, andMpiClientServiceImplthat cause Java compilation errorsparseFhirPatient()call signature inFhirMpiClientServiceImpl.getPatientList()— was passing 1 arg, method requires 2Test plan
mvn packagecompiles and all tests pass