Skip to content

Fix CI workflow and remove duplicate method definitions - #61

Closed
mherman22 wants to merge 1 commit into
IsantePlus:mainfrom
mherman22:chore/ci-and-compile-fixes
Closed

Fix CI workflow and remove duplicate method definitions#61
mherman22 wants to merge 1 commit into
IsantePlus:mainfrom
mherman22:chore/ci-and-compile-fixes

Conversation

@mherman22

Copy link
Copy Markdown

Summary

  • Update deprecated GitHub Actions that cause CI failures:
    • actions/checkout v2 → v4
    • actions/setup-java v1 → v4 (with temurin distribution)
    • actions/cache v2 → v4
    • stCarolas/setup-maven v4 → v5
    • Replace s4u/maven-settings-action with setup-java built-in Maven server config
  • Remove duplicate getPatientList() method definitions in MpiClientService, MpiClientWorker, and MpiClientServiceImpl that cause Java compilation errors
  • Fix parseFhirPatient() call signature in FhirMpiClientServiceImpl.getPatientList() — was passing 1 arg, method requires 2

Test plan

  • CI workflow runs successfully on push/PR
  • mvn package compiles and all tests pass

- Update deprecated GitHub Actions: checkout v2→v4, setup-java v1→v4,
  cache v2→v4, setup-maven v4→v5
- Replace s4u/maven-settings-action with setup-java built-in server config
- Remove duplicate getPatientList() definitions in MpiClientService,
  MpiClientWorker, and MpiClientServiceImpl that caused compile errors
- Fix parseFhirPatient() call signature in FhirMpiClientServiceImpl
@mherman22

Copy link
Copy Markdown
Author

CI failure is a pre-existing issue

The build fails because the github-packages Maven repository at https://maven.pkg.github.com/isanteplus/isanteplus-packages requires authentication, and the RELEASE_USERNAME / RELEASE_TOKEN secrets are not available for fork PRs.

This affects all fork PRs, not just this one — the everest-core:1.1.0 dependency can't be resolved without valid credentials.

The code compiles and all 21 tests pass locally:

Tests run: 21, Failures: 0, Errors: 0, Skipped: 0

To fix CI for fork PRs, the workflow could use GITHUB_TOKEN (automatically available) instead of custom secrets, or the isanteplus-packages registry could be made public.

@mherman22

Copy link
Copy Markdown
Author

Folded into #60.

@mherman22 mherman22 closed this Apr 9, 2026
@mherman22
mherman22 deleted the chore/ci-and-compile-fixes branch April 15, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant