Updates for core module setup - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the core module setup by revising module metadata files, removing deprecated modules, and adjusting build/deployment scripts.
- Updated .omod files for various modules in both distribution and custom_modules directories.
- Removed legacy modules and configuration files from packages and config directories.
- Modified Dockerfile and mk.sh to reflect the new build process and module locations.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/emr-isanteplus/distribution/openmrs_modules/*.omod | New module metadata files added and legacy ones removed to update module versions. |
| projects/emr-isanteplus/distribution/custom_modules/*.omod | New module metadata files added for custom modules. |
| projects/emr-isanteplus/Dockerfile | Added a comment for custom_modules and preserved entrypoint execution. |
| packages/emr-isanteplus/xds-sender-2.4.0-SNAPSHOT.omod | Removed outdated module file. |
| packages/emr-isanteplus/package-metadata.json | Updated dependency list by removing "database-mysql". |
| packages/emr-isanteplus/config/custom_modules/*.omod | Removed outdated configuration module files. |
| packages/emr-isanteplus/Dockerfile | Removed custom_modules copy command from configuration build. |
| mk.sh | Adjusted build script execution to favor the custom modules build process. |
Comments suppressed due to low confidence (2)
packages/emr-isanteplus/package-metadata.json:7
- Removing the 'database-mysql' dependency could impact system initialization if other configurations expect it; please ensure that this removal is intentional and that dependency management is updated accordingly.
"dependencies": [],
packages/emr-isanteplus/Dockerfile:1
- The removal of the custom_modules directory copy command may affect module availability; verify that this change aligns with the updated deployment strategy.
-add ./config/custom_modules /custom_modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.