Switch to scalafix, apply fmt/lint fixes automatically#163
Open
giarc3 wants to merge 3 commits into
Open
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4a90396 |
coltfred
requested changes
Jun 26, 2026
| with: | ||
| path: ${{ env.UNDER_TEST_FOLDER }} | ||
| # When pushable, check out the PR branch tip (not the merge ref) with the PAT so the auto-fix commit can be pushed back. | ||
| ref: ${{ steps.push_mode.outputs.can_push == 'true' && github.head_ref || '' }} |
Member
There was a problem hiding this comment.
empty string ref will probably error if it ever happens. Should we just error here?
Member
Author
There was a problem hiding this comment.
I don't think that errors, I think that falls back to default behavior of the merge ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses our WORKFLOW_PAT to automatically commit scalafmt and scalafix changes to the branch, then CI will re-run on that new commit. If it can't make the fixes, it will fall back to doing a check like before