feat(discovery): add discover_devices_stream streaming variant - #54
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces discover_devices_stream, an asynchronous generator that yields discovered dLight devices incrementally as they respond. It also updates the documentation and adds unit tests for this new feature. The reviewer feedback highlights a potential data loss issue in the streaming loop if consumer processing delays cause a timeout, suggesting yielding all buffered devices before exiting. Additionally, the reviewer suggests making the results_list parameter optional in _DiscoveryProtocol to avoid unnecessary list allocations during streaming discovery.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…nal and draining the queue before exiting
Closes #33