Skip to content

chore: add pre-commit configuration and issue skill - #51

Merged
Irishsmurf merged 3 commits into
mainfrom
feat/pre-commit-and-skills
Jun 13, 2026
Merged

Irishsmurf merged 3 commits into
mainfrom
feat/pre-commit-and-skills

Conversation

@Irishsmurf

Copy link
Copy Markdown
Owner

This PR adds a pre-commit hook configuration for Ruff, updates the contributing guidelines, formats the codebase, and adds a new custom /issue skill for both Claude Code and Gemini.

@Irishsmurf
Irishsmurf merged commit f352ce8 into main Jun 13, 2026
5 checks passed
@Irishsmurf
Irishsmurf deleted the feat/pre-commit-and-skills branch June 13, 2026 22:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces pre-commit hooks using Ruff, updates the contributing guidelines to include pre-commit setup, adds a Claude Code issue workflow command, and exports Claude Code skills as Gemini function declarations. It also applies minor code formatting cleanups across several files. The reviewer feedback suggests enhancing the pre-commit configuration with standard hygiene hooks (such as trailing whitespace and YAML checkers) and removing the redundant flake8 dependency from the installation instructions in CONTRIBUTING.md.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .pre-commit-config.yaml
Comment on lines +1 to +7
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.5.0
hooks:
- id: ruff
args: [--fix]
- id: ruff-format

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure general repository hygiene beyond Python files, it is highly recommended to include standard pre-commit hooks such as trailing-whitespace, end-of-file-fixer, and check-yaml. This helps maintain consistent formatting across all file types (e.g., Markdown, YAML, JSON).

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.6.0
    hooks:
      - id: trailing-whitespace
      - id: end-of-file-fixer
      - id: check-yaml
      - id: check-added-large-files
  - repo: https://github.com/astral-sh/ruff-pre-commit
    rev: v0.5.0
    hooks:
      - id: ruff
        args: [--fix]
      - id: ruff-format

Comment thread CONTRIBUTING.md
python -m venv .venv && source .venv/bin/activate
pip install -e .
pip install pytest pytest-asyncio flake8 ruff
pip install pytest pytest-asyncio flake8 ruff pre-commit

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since Ruff is being introduced as the primary linter and formatter (and is configured in the pre-commit hooks), flake8 is now redundant. Removing it from the installation instructions reduces dependency bloat and avoids potential conflicts between different linting tools.

Suggested change
pip install pytest pytest-asyncio flake8 ruff pre-commit
pip install pytest pytest-asyncio ruff pre-commit
References
  1. Avoid redundant linting and formatting tools to prevent conflicting rules and reduce dependency overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant