Clean up test suite formatting and annotations#164
Merged
Conversation
Three small, mechanical hygiene fixes that have been accumulating in the test suite: 1. Drop the unused `import nielsen.config` from `tests/test_tvmaze.py`. 2. Tighten bare `dict` and `list[dict]` annotations across `tests/test_tvmaze.py` to `dict[str, Any]` / `list[dict[str, Any]]`. Bare `dict` infers as `dict[Any, Any]`, which silently allows wrong-shaped fixtures through; the tighter form documents the expected JSON shape. 3. Reformat multi-line `assert ..., "msg"` statements to the parenthesized-message style preferred by Ruff's default formatter (one occurrence in `test_tv.py`, five in `test_tvmaze.py`). Resolve #141.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, mechanical hygiene fixes that have been accumulating in the test suite:
import nielsen.configfromtests/test_tvmaze.py.dictandlist[dict]annotations acrosstests/test_tvmaze.pytodict[str, Any]/list[dict[str, Any]]. Baredictinfers asdict[Any, Any], which silently allows wrong-shaped fixtures through; the tighter form documents the expected JSON shape.assert ..., "msg"statements to the parenthesized-message style preferred by Ruff's default formatter (one occurrence intest_tv.py, five intest_tvmaze.py).Resolve #141.