Trust Let's Encrypt ISRG Root YR cross-sign for spaceships.app - #27
Merged
Conversation
search.spaceships.app now chains to the new Let's Encrypt root "ISRG Root YR" and serves an incomplete chain that omits the cross-sign to the trusted ISRG Root X1. That root is not yet in Node's bundled CA store, so axios requests fail TLS verification with UNABLE_TO_GET_ISSUER_CERT_LOCALLY. Browsers hide this by fetching the missing cert via AIA chasing; strict clients such as Node, curl and wget do not. Ship the ISRG Root X1 cross-sign of Root YR in the runtime image and point NODE_EXTRA_CA_CERTS at it. This supplies the missing bridge to the already trusted root without disabling any certificate verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search.spaceships.app now chains to the new Let's Encrypt root "ISRG Root YR" and serves an incomplete chain that omits the cross-sign to the trusted ISRG Root X1. That root is not yet in Node's bundled CA store, so axios requests fail TLS verification with UNABLE_TO_GET_ISSUER_CERT_LOCALLY. Browsers hide this by fetching the missing cert via AIA chasing; strict clients such as Node, curl and wget do not.
Ship the ISRG Root X1 cross-sign of Root YR in the runtime image and point NODE_EXTRA_CA_CERTS at it. This supplies the missing bridge to the already trusted root without disabling any certificate verification.