-
Notifications
You must be signed in to change notification settings - Fork 24
POC for polysemy #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
POC for polysemy #771
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| {-# LANGUAGE DataKinds #-} | ||
| {-# LANGUAGE FlexibleContexts #-} | ||
| {-# LANGUAGE OverloadedStrings #-} | ||
| {-# LANGUAGE TypeApplications #-} | ||
Check warningCode scanning / HLint Unused LANGUAGE pragma
cardano-cli/src/Cardano/CLI/Polysemy.hs:4:1-33: Warning: Unused LANGUAGE pragma
Found:
{-# LANGUAGE TypeApplications #-}
Perhaps you should remove it.
|
||
| {-# LANGUAGE TypeOperators #-} | ||
Check warningCode scanning / HLint Unused LANGUAGE pragma
cardano-cli/src/Cardano/CLI/Polysemy.hs:5:1-30: Warning: Unused LANGUAGE pragma
Found:
{-# LANGUAGE TypeOperators #-}
Perhaps you should remove it.
Note: may require `{-# LANGUAGE ExplicitNamespaces #-}` adding to the top of the file
|
||
|
|
||
| module Cardano.CLI.Polysemy | ||
| ( ByronKeyFailure(..), | ||
| ByronKeyFormat(..), | ||
| SigningKeyFile, | ||
| File(..), | ||
| FileDirection(..), | ||
| readByronSigningKey | ||
| ) where | ||
|
|
||
| import Cardano.Api.Byron (SomeByronSigningKey (..)) | ||
|
|
||
| import Cardano.CLI.Byron.Key (ByronKeyFailure (..)) | ||
| import qualified Cardano.CLI.Byron.Key as Cli | ||
| import Cardano.CLI.Types.Common | ||
|
|
||
| import Control.Monad.Except (runExceptT) | ||
|
|
||
| import HaskellWorks.Polysemy | ||
| import HaskellWorks.Polysemy.Prelude | ||
| import Polysemy () | ||
|
|
||
| readByronSigningKey :: () | ||
| => Member (Error ByronKeyFailure) r | ||
| => Member (Embed IO) r | ||
| => ByronKeyFormat | ||
| -> SigningKeyFile In | ||
| -> Sem r SomeByronSigningKey | ||
| readByronSigningKey bKeyFormat fp = | ||
| (embed $ runExceptT $ Cli.readByronSigningKey bKeyFormat fp) | ||
| & onLeftM throw | ||
|
Comment on lines
+35
to
+36
Check noticeCode scanning / HLint Move brackets to avoid $
cardano-cli/src/Cardano/CLI/Polysemy.hs:(35,3)-(36,19): Suggestion: Move brackets to avoid $
Found:
(embed $ runExceptT $ Cli.readByronSigningKey bKeyFormat fp)
& onLeftM throw
Perhaps:
embed (runExceptT $ Cli.readByronSigningKey bKeyFormat fp)
& onLeftM throw
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / HLint
Unused LANGUAGE pragma