Skip to content

test: add url utility for bot review #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramonasuncion wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add url utility for bot review #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added pythonbridge/utils/__init__.py
View file
Open in desktop
Empty file.
13 changes: 13 additions & 0 deletions pythonbridge/utils/url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
def parse_url(url):
parts = url.split("://")
if len(parts) != 2:

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 [HIGH] Bug: parse_url can return None here but its callers are not checked. Add a check to handle None return values.

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 [MEDIUM] ValueError: parse_url returns None for URLs with no protocol or more than one '://' (e.g. 'example.com', 'http://example.com//path'). Consider raising a ValueError with a descriptive message instead of returning None.

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 [HIGH] Bug: parse_url returns None for URLs without a scheme (e.g. //example.com), but does not handle cases where the URL has multiple schemes (e.g. http://https://example.com). Consider raising a ValueError instead of returning None.

return None

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 [MEDIUM] TypeError: parse_url returns None for invalid URLs but the caller might not check for it, leading to a TypeError when trying to access the returned value as a tuple. Consider raising a ValueError instead of returning None.

return parts[0], parts[1]


def is_secure(url):
return url.startswith("https://")

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 [LOW] Style: The security check only considers 'https' as secure. Consider supporting other secure protocols like 'sftp' or 'ssh' as well.

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 [LOW] Insecurity: is_secure only checks if the URL starts with 'https://', but does not account for other secure protocols like 'sftp://'. Consider using a more comprehensive check, such as url.startswith(('https://', 'sftp://')).



def get_path(url):
return url.split("/", 3)[3]

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 [MEDIUM] Bug: get_path does not handle the case when the URL does not contain a path. Add error checking for this scenario.

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 [HIGH] IndexError: get_path raises IndexError when the URL has fewer than 4 path segments (e.g. 'https://example.com', 'https://example.com/path'). Use url.split('/', 3) and check the length of the result before indexing.

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 [HIGH] IndexError: get_path raises an IndexError when the URL has less than 4 path segments (e.g. https://example.com). Use url.split('/', 3) and check the length of the result before indexing it, or use a try-except block to catch the IndexError.

@snipercodeai snipercodeai Bot May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 [MEDIUM] IndexError: get_path raises IndexError when the URL has no path segment (e.g. https://example.com). Use url.split('/', 3)[3] if len(url.split('/', 3)) > 3 else ''.

Loading