fix(itk-wasm): spell TimeVaryingVelocityField parameterizations with the y - #1592
Merged
thewtex merged 1 commit intoAug 25, 2026
Conversation
…the y The TransformParameterizations table spelled two entries TimeVaringVelocityField and GaussianSmoothingOnUpdateTimeVaringVelocityField, both as key and as value. Everywhere else the name carries the y: the JSONTransformParameterizationEnum in itkTransformJSON.h, the C++ class names the serializer matches on, and the Python itkwasm TransformParameterizations enum. A TypeScript consumer comparing transformParameterization against any of those never matched these two entries. Correct the four spellings and add a test that every value is its own key and that the two time-varying entries match the ITK class names. Closes InsightSoftwareConsortium#1591
thewtex
approved these changes
Aug 25, 2026
thewtex
merged commit Aug 25, 2026
89122ba
into
InsightSoftwareConsortium:main
67 of 74 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TransformParameterizationstable inpackages/core/typescript/itk-wasm/src/interface-types/transform-parameterizations.tsspelled two entriesTimeVaringVelocityFieldandGaussianSmoothingOnUpdateTimeVaringVelocityField, both as key and as value. Everywhere else the name carries the y:JSONTransformParameterizationEnumininclude/itkTransformJSON.h, the C++ class names the serializer matches on (TimeVaryingVelocityFieldTransform,GaussianSmoothingOnUpdateTimeVaryingVelocityFieldTransform), and the Pythonitkwasm.TransformParameterizationsenum. A TypeScript consumer comparingtransformParameterizationagainst any of those never matched these two entries.This corrects the four spellings and adds
test/node/interface-types/transform-parameterizations-test.js, which checks that every value is its own key and that the two time-varying entries match the ITK class names.The C++ side never emitted the misspelled strings (it writes from the enum in
itkTransformJSON.h), so no reader needs to accept the old spelling. The two keys change name in the TypeScript API for callers that referencedTransformParameterizations.TimeVaringVelocityFielddirectly.Verified locally:
tscbuild,avaon the new test andtransform-type-test.js(6 passed),standardandts-standardclean.Closes #1591