Skip to content

fix(itkwasm): support wasmtime 48 #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vboussot wants to merge 1 commit into from
Closed

fix(itkwasm): support wasmtime 48 #1588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/core/python/itkwasm/itkwasm/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@
WasiConfig,
Linker,
WasmtimeError,
DirPerms,
FilePerms
)

# Get the value of the ITKWASM_CACHE_DIR environment variable
Expand Down Expand Up @@ -86,7 +84,12 @@ def __init__(
wasi_config.argv = args

for preopen in preopen_directories:
wasi_config.preopen_dir(preopen, preopen, DirPerms.READ_WRITE, FilePerms.READ_WRITE)
# Read-write is the default on both sides of the wasmtime 48.0.0
# signature change: `dir_perms=DirPerms.READ_WRITE,
# file_perms=FilePerms.READ_WRITE` up to 47.0.1, `fs_mutable=True`
# from 48.0.0, where the two enums were removed. Passing neither
# keeps read-write across the supported range.
wasi_config.preopen_dir(preopen, preopen)

store.set_wasi(wasi_config)

Expand Down
Loading