itk wasm dist - #1585
Merged
Merged
Conversation
thewtex
commented
Aug 11, 2026
thewtex
commented
Member
- fix(packaging): declare files so pnpm 11 ships dist
- chore(itk-wasm): bump version to 1.0.0-b.201
pnpm 11 re-anchors workspace root .gitignore patterns to the package being packed, so the root `dist/*` rule (intended for the documentation site) matched `<package>/dist/*` and stripped the build output from the tarball. itk-wasm 1.0.0-b.200 published with no dist/ at all, leaving every module, types, and exports entry pointing at a missing file. Bindgen-generated packages were unaffected because they ship an .npmignore, which stops the walk up to the workspace root. Declare "files" on the three hand-maintained core TypeScript packages instead, which takes precedence over ignore files entirely. Anchoring the root rule as `/dist/*` does not help, since pnpm re-anchors it either way. Verified with pnpm 11.21.0: itk-wasm packs 363 dist files (matching b.199), @itk-wasm/demo-app 2052, and create-itk-wasm 84. Nothing referenced the previously packed test/, tsconfig.json, or playwright.config.js. Add an ava regression test covering both the manifest declaration and the actual pnpm pack output. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.