style: Declare data of Stream classes private, instead of protected - #1422
Merged
thewtex merged 1 commit intoJul 18, 2025
Merged
Conversation
Contributor
Author
|
@thewtex The CI rejects this PR at PR Checks / Check and lint PR (pull_request), saying: Could this commit check possibly be extended, to allow ITK style commit text? |
Following C++ Core Guidelines, Jul 8, 2025, "Avoid `protected` data", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-protected
N-Dekker
force-pushed
the
Declare-Stream-data-private
branch
from
July 18, 2025 12:45
733b6fd to
0fb1638
Compare
Member
|
👍 @N-Dekker thank you!
These are the conventions of a broadly adopted standard, Conventional Commit: https://www.conventionalcommits.org/en/v1.0.0/ that is used throughout the web community, and has a bunch of tooling built around it. Since this is a web-oriented project and we use some of that tooling, we use this convention. |
private, instead of protectedprivate, instead of protected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following C++ Core Guidelines, Jul 8, 2025, "Avoid
protecteddata"