Skip to content

fix: add VariableReference in variable for ucq - #185

Merged
nsenave merged 7 commits into
mainfrom
fix/ucq-variables-reference
Mar 2, 2026
Merged

fix: add VariableReference in variable for ucq#185
nsenave merged 7 commits into
mainfrom
fix/ucq-variables-reference

Conversation

@QRuhier

@QRuhier QRuhier commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

This property is required for the "variable choices in unique choice question" feature, it was missing

@RemiVerriez
RemiVerriez requested a review from nsenave February 25, 2026 07:48

@nsenave nsenave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retour sur la doc de 'VariableReference' dans l'objet vairble

VariableReference indicates the collected variable whose values
dynamically define the response options when the question
choiceType is set to VARIABLE.
It must not be used when choiceType is CODE_LIST.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est un peu bizarre de parler de "cette question est de type 'liste de code'" dans un objet variable 🤔

Après j'avais pas conscience (ou plus en mémoire) qu'on a déjà la prop "CodeListReference"

proposition de reformulation :

Property defined on variables associated with a choice question, whose choices are dynamically defined by the responses of another question.

The value of the 'VariableRerference' property is the identifier of the variable defining these dynamic choices.

Therefore, it must only be used when the 'choiceType' in the associated question is 'VARIABLE'.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je commit ce changement

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread pom.xml Outdated
<groupId>fr.insee.pogues</groupId>
<artifactId>pogues-model</artifactId>
<version>1.15.1</version>
<version>1.16.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un détail : si c'est un fix c'est le patch qu'il faut monter

Sinon changer en feat:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2026

Copy link
Copy Markdown

@nsenave nsenave changed the title fix: add variableReference in variable for ucq fix: add VariableReference in variable for ucq Mar 2, 2026

@nsenave nsenave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sous réserve que la modélisation est conforme à ce qu'on veut dans Pogues (mais j'imagine que oui)

Bien joué pour les tests @RemiVerriez ! 👍

@nsenave
nsenave merged commit 3943aa9 into main Mar 2, 2026
5 checks passed
@nsenave
nsenave deleted the fix/ucq-variables-reference branch March 2, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants