UI scene lifecycle migration - #53
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the iOS side of the plugin to properly support UIKit’s scene-based lifecycle (UISceneDelegate), while also tightening the project’s minimum platform/tooling requirements and fixing a couple of login/init edge cases.
Changes:
- Raise minimum requirements (Flutter >= 3.38, iOS >= 13) and bump package version to 3.1.0.
- iOS: add scene URL handling + improve view controller lookup for presenting VK SDK UI; fix init/login completion on authorization failure.
- Android: treat stored-token permission check failures as a signal to drop invalid tokens (while avoiding reset on connection errors).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates documented minimum requirements (Flutter/iOS). |
| pubspec.yaml | Bumps package version and raises Flutter minimum SDK constraint. |
| ios/flutter_login_vk.podspec | Raises iOS deployment target to 13.0. |
| ios/Classes/SwiftFlutterLoginVkPlugin.swift | Adds UIScene URL handling; improves UI presentation controller lookup; fixes init/login completion behavior. |
| example/pubspec.lock | Updates example lockfile to match new package version and SDK constraints. |
| CHANGELOG.md | Adds 3.1.0 release notes describing breaking requirements and fixes. |
| android/src/main/kotlin/ru/innim/flutter_login_vk/MethodCallHandler.kt | Drops stored token when permission check fails (except for IO/connection errors). |
| .idea/libraries/Dart_SDK.xml | Updates local IDE Dart SDK library paths. |
| .github/workflows/publish.yml | Updates publish workflow Flutter version reference. |
| .github/workflows/analyze.yml | Updates CI analyze workflow Flutter version. |
| .fvmrc | Updates pinned Flutter version for FVM. |
Files not reviewed (1)
- .idea/libraries/Dart_SDK.xml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greymag
requested changes
Jul 23, 2026
greymag
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.