docs(8): report job-definition schema coverage holes#9
Merged
Conversation
Inspect all 18 Job Definition files against the decoder schema and document where the schema does not explicitly cover their content: - top-level and `job` objects lack `additionalProperties: false`, so unknown keys (repository-url/tag, misplaced options) pass silently - option properties use unmodelled `minValue`/`maxValue` (hard fail) - several other objects share the same silent-hole pattern Report only; schema changes belong in the decoder submodule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Inspects all 18 deployed Job Definition files against the decoder's
job-definition-schema.yamland reports where the schema does not explicitlycover their content. Deliverable is a report only — no schema or job-file
changes (schema changes belong in the
squonk2-data-manager-job-decodersubmodule).
Findings
17 of 18 files fully conform. Every hole comes from
virtual-screening/data-manager/moldb.yaml, but each exposes a real gap:additionalProperties: false→repository-url/repository-tagpass silently (modelled nowhere).jobobject lacksadditionalProperties: false→options:placeddirectly on
moldb-count-rows(should be undervariables:) is silentlyignored.
minValue/maxValue, which the schema does notmodel (it has
minimum/maximum) — the only case that actually failsvalidation (9 errors).
checks,test-checks-outputand thevalue-frominner objectsshare the same silent-hole pattern.
Changes
docs/schema-coverage.md— the report (method, holes table, details,recommended schema extensions, reproducible validation script + output).
docs/README.md— links the new document from the Contents table.🤖 Generated with Claude Code