[NguyenHoangSon96]

Closes #

Proposed Changes

• How the errors are handled and test cases adjustment in this PR are heavily influenced by this PR.

Changes

• Tests were modified to accommodate with new definitions of partial write errors, which are:
  - Error response status code is 400.
  - Error response format {"error":"...","data":[{"error_message":"...","line_number":2,"original_line": "..."}]} is returned with data must be an array.
  - accept_partial is set to true.
  - Write endpoint must be api/v3/write_lp.

Checklist

• CHANGELOG.md updated
• Rebased/mergeable
• A test has been added if appropriate
• Tests pass
• Commit messages are conventional
• Sign CLA (if not already signed)

[Copilot]

🟡 Changes recommended

There are confirmed correctness/quality issues in the updated error-message formatting logic and test setup (notably null content-type handling and a misleading integration test name) that should be fixed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR tightens how v3 write (/api/v3/write_lp) “partial write” responses are detected and surfaced, aiming to throw InfluxDBPartialWriteException only when the response matches the expected partial-write shape and the client accepts partial writes, while improving error-message formatting and expanding unit/integration coverage.

Changes:

• Classify partial-write errors based on HTTP status, endpoint path, accept_partial, and JSON shape (data array), rather than string-matching error text.
• Improve formatting for v3 error responses that include data.error_message / line_number / original_line.
• Update and expand tests to cover structured vs unstructured partial write behavior and message formatting.

File summaries

File	Description
Client/Internal/RestClient.cs	Refines partial-write detection and error parsing/formatting for v3 write errors.
Client.Test/Internal/RestClientTest.cs	Updates existing assertions and adds parameterized coverage for partial-write classification and formatting.
Client.Test.Integration/WriteTest.cs	Adjusts integration expectations around AcceptPartial=false behavior.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 4
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The behavioral change is well-covered by expanded tests, and the remaining review notes are minor robustness/cleanliness improvements.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 3
• Review effort level: Lite

[karel-rehor]

Comparison with the similar changes in GO is OK. Where in GO I see <Tokens>Error here we have <Tokens>Exception where the preceding tokens reflect the same naming.

I see that Go wraps the logic starting on line 84 of RestClient.cs into a method classifyWriteError(err,options). I might suggest a similar method here

internal Exception ClassifyException(result, queryParams) {
   // logic from current block
}
...
   if(!result.IsSuccessStatusCode)
   {
      throw ClassifyException(result, queryParams)
   }

However since this code is all internal and not public facing, this is just a suggestion.

Still we should probably clean up warnings about possible derefrencing of possible null arguments.

Further review TBC.

[Copilot]

🟡 Changes recommended

Address the two moderate test coverage issues before approval.

1 open finding

• Use the production V2 write route in classification test · New

3 resolved since last review

• path.Equals("api/v3/write_lp") uses the culture-sensitive string.Equals overload. For request…
• accept_partial is treated as true unless the value is exactly "false" (case-sensitive), and the…
• parsedLineNumber is assigned in the int.TryParse(..., out var parsedLineNumber) call but never…

🧠 Review effort: Lite

[NguyenHoangSon96]

Hi @karel-rehor
Changes pushed, please check again.

[karel-rehor]

Just one small quibble about name of a self-descriptive local variable, which required some extra time for understanding the block where it is declared.

[karel-rehor]

Tests pass locally.

Looks good to me. 🚴 🏁