Fix time functions - #33
Merged
Merged
Conversation
include variable initial guess fit recovery here rather than pytest because static initial guesses are meaningless and variable/random ones could break test pipeline in a non-reproducable way
Breaking change. The per-function y0 offset broke the causality convention f(t < t0) = 0 inconsistently across dynamics functions (sqrtFun/erfFun leaked y0 before t0; the rest clamped to 0) and duplicated what an additive component already expresses. Drop y0 from linFun, expFun, sinFun, sinDivX, erfFun, and sqrtFun, and add stepFun(t, A, t0) as the dedicated causal offset primitive (erfFun is its Gaussian-broadened counterpart). Offsets and plateaus are now modeled by adding a stepFun component, e.g. expFun + stepFun sharing t0 for a decay to a nonzero plateau. Wire stepFun through both evaluation paths (mcp and the lowered GIR/eval_2d dispatch, new DynFuncKind.STEPFUN) and migrate every model YAML, notebook, and doc that referenced dynamics y0 (all values were 0, so pure deletions). Stale y0 entries now fail model validation with a parameter-count error. The energy-domain Offset(x, y0) background is unchanged. Also from the functions audit: - correct docstrings: expRiseCONV (anti-causal, not causal), boxCONV (hard edges, no smoothing), GLS/GLP (valid range m in [0, 1]; GLP gives NaN/inf for m < 0), DS (asymmetric tail extends toward x < x0). - add end-to-end lowered-2D parity tests for every dynamics driver (stepFun, sinFun, linFun, sinDivX, erfFun, sqrtFun), verifying each DynFuncKind enum/dispatch entry and param count against the mcp interpreter -- previously only expFun was exercised this way, and this change decremented all those param counts.
and housekeeping: author e-mail reset PLAN md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.