Add bounds checking for AS path segment types

[IlianaXn]

Add the same check in append_segments_all as in the append_segments:

libbgpstream/lib/formats/bgpstream_parsebgp_common.c

Lines 92 to 98 in 04e7b30

	// ensure we're not going to wander off the end of as_path_types array
	if (seg->type < PARSEBGP_BGP_UPDATE_AS_PATH_SEG_AS_SET ||
	seg->type > PARSEBGP_BGP_UPDATE_AS_PATH_SEG_CONFED_SET) {
	bgpstream_log(BGPSTREAM_LOG_ERR, "Unknown AS Path segment type %d",
	seg->type);
	return -1;
	}

[Copilot]

Pull request overview

This PR adds defensive bounds checking in append_segments_all to match the existing validation already present in append_segments, preventing out-of-bounds access into the as_path_types lookup table when encountering unexpected AS_PATH segment types.

Changes:

• Add validation of seg->type range in append_segments_all before indexing as_path_types.
• Log an error and return -1 when an unknown AS path segment type is encountered.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.