Add an attribute for a point preceding a filter#152
Open
Tom Holland (tomjholland) wants to merge 5 commits into
Open
Add an attribute for a point preceding a filter#152Tom Holland (tomjholland) wants to merge 5 commits into
Tom Holland (tomjholland) wants to merge 5 commits into
Conversation
Tom Holland (tomjholland)
added
the
feature
Tom Holland (tomjholland)
marked this pull request as ready for review
October 18, 2024 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pyprobecodebase, focusing on adding new functionality for handling preceding points in data frames.Handling Preceding Points:
pyprobe/filters.py: Addedpreceding_pointsattribute toProcedure,Experiment,Cycle, andStepclasses. [1] [2] [3] [4] [5]pyprobe/filters.py: Added_get_preceding_pointsstatic method toProcedureclass to extract rows prior to the first point of each event.pyprobe/filters.py: Updated methods to includepreceding_pointsin their parameters and initialization. [1] [2] [3]Test Updates:
tests/analysis/test_cycling.py: UpdatedCycling_fixtureto includepreceding_pointsattribute.tests/test_procedure.py: Added tests forget_preceding_pointsmethod and updated existing tests to check forpreceding_pointsattribute. [1] [2] [3]tests/test_rawdata.py: UpdatedRawData_fixtureto includepreceding_pointsattribute. [1] [2]