Repository navigation
fix(otel): HTTP server spans carry the Required url.scheme and url.path (E1) - #53
Merged
Merged
Conversation
…th (E1) Every HTTP server span omitted url.scheme and url.path, both Required on HTTP server spans by the semantic conventions. They are now derived from the calling client's url.full, and server.address/server.port mirror the host the client called, so a client span and the server span it produced agree on where the request went. Safe for every DeepCube client: it adds attributes and removes none. It also lets older clients see shop.example.com answered. Client-span host attributes (E2) are held back because they create new "no server" candidates on clients without the D-C detector change. AB#3428, SP-120. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ETWOYA
previously approved these changes
Sep 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ETWOYA
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#3428 (SP-120, E1).
Every HTTP server span omitted
url.schemeandurl.path, both Required on HTTP server spans by the OpenTelemetry semantic conventions (http-spans). They are now derived from the calling client'surl.full, andserver.address/server.portmirror the host the client called, so each client span and the server span it produced agree on where the request went.shop.example.comanswered by the api-gateway, which removes that phantom from every grid.047901b(36 violations plus the healthz path mismatch), green after (go test ./..., 23 pass).Deliberately not in this PR: E2 (host attributes on five client spans). On clients without the D-C detector change, E2 creates new phantoms (
api.sendgrid.com,elasticsearch.internal), and Argo auto-syncs a pin bump in minutes. It is held until that ruling.Deploying still takes a separate IF.GitOps pin bump after a release tag.
🤖 Generated with Claude Code