Skip to content

Run tests and a packaging check on pull requests - #11

Merged
ETWOYA merged 1 commit into
mainfrom
friday/ci-on-pull-requests
Sep 3, 2026
Merged

ETWOYA merged 1 commit into
mainfrom
friday/ci-on-pull-requests

Conversation

@dankoverride

Copy link
Copy Markdown
Collaborator

Why

The only workflow triggered on version tags, so nothing ran on a pull request. PR #10 merged to main with zero automated checks, and the 86 tests it added would first have executed after a release tag, which is after the code had already landed.

What

A CI workflow on pull_request and pushes to main. Release packaging stays in build.yml on tags only, so a pull request does not rebuild all six platforms.

Two jobs:

  • test — dotnet test across the solution.
  • package — publishes one representative RID (linux-x64) and asserts the output really is a single self-contained dcp that boots as far as its startup key check. Publishing previously only ran at tag time, so a broken single-file publish stayed invisible until a release was already being cut.

The package job deliberately runs one RID rather than the full six-platform matrix: it catches packaging regressions on the PR without paying for the whole release build on every push.

🤖 Generated with Claude Code

The only workflow triggered on version tags, so nothing ran on a pull request.
PR #10 merged to main with zero automated checks, and the tests it added would
first have executed after a release tag, which is after the code had landed.

Adds a CI workflow on pull_request and pushes to main. Release packaging stays in
build.yml on tags only, so a pull request does not build all six platforms.

Alongside the tests it publishes one representative RID and asserts the output is
a single self-contained dcp that reaches its startup key check. A broken
single-file publish previously stayed invisible until a release was being cut.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ETWOYA
ETWOYA merged commit 8b41f09 into main Sep 3, 2026
2 checks passed
@dankoverride
dankoverride deleted the friday/ci-on-pull-requests branch September 3, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants