Skip to content

Keep channels in Volume.copy #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asaraog wants to merge 2 commits into from
Closed

Keep channels in Volume.copy #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
923d3f1
Test that Volume.copy keeps channels
asaraog Sep 26, 2026
67b0c33
Keep channels in Volume.copy
asaraog Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/highdicom/volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2972,6 +2972,7 @@ def copy(self) -> Self:
affine=self._affine.copy(),
coordinate_system=self.coordinate_system,
frame_of_reference_uid=self.frame_of_reference_uid,
channels=self._channels,
)

def with_array(
Expand Down
12 changes: 12 additions & 0 deletions tests/test_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,3 +1584,15 @@ def test_reassign_dtype(dtype):
)
):
volume.array = np.zeros((10, 10, 10), dtype=dtype)


def test_copy_keeps_channels():
vol = Volume(
array=np.zeros((2, 3, 3, 2), dtype=np.uint8),
affine=np.eye(4),
coordinate_system="PATIENT",
channels={'SegmentNumber': [1, 2]},
)
copied = vol.copy()
assert copied.channel_shape == vol.channel_shape
assert copied.get_channel_values('SegmentNumber') == [1, 2]
Loading