Repository navigation
Validate ImageFileReader frame indices - #444
Merged
CPBridge merged 1 commit intoJul 28, 2026
Merged
Conversation
yinkev
marked this pull request as draft
July 25, 2026 20:59
Collaborator
|
Is this ready for review? @yinkev |
Collaborator
|
Could you please resolve the merge conflicts too (I think you just want to keep both changes)? |
Signed-off-by: kyinhub <kevinpyin@gmail.com>
yinkev
marked this pull request as ready for review
July 27, 2026 21:34
yinkev
force-pushed
the
bugfix/image-reader-frame-bounds
branch
from
July 27, 2026 21:34
3761f87 to
3b34bad
Compare
Contributor
Author
|
Good catch, leaving it as a draft was accidental. I resolved the merge conflict by keeping both changes and marked it ready for review. Thanks for catching it. |
CPBridge
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #439.
Summary
NumberOfFramesValueErrorcontract on raw and decoded frame accessRoot cause
The previous condition used
index > number_of_frames. It therefore allowed Python negative indexing and missed the first invalid upper-bound value,index == number_of_frames.Validation
upstream/mastertests/test_io.py: 111 passed, 9 skippedgit diff --check